ref(night-shift): Use seer-project-settings helpers for project eligibility by chromy · Pull Request #112936 · getsentry/sentry

chromy · 2026-04-14T16:32:47Z

Add a unified `bulk_read_preferences()` helper in `autofix/utils.py` that
returns `dict[int, SeerProjectPreference | None]` regardless of whether
preferences are read from Sentry DB or the Seer API. The helper checks the
`seer-project-settings-read-from-sentry` feature flag internally so callers
don't need to duplicate that branching logic.

Use the new helper in the night-shift cron's `_get_eligible_projects`,
replacing the direct `SeerProjectRepository` query. The
`autofix_automation_tuning != OFF` filter is preserved on top of the
preference check.

src/sentry/seer/autofix/utils.py

src/sentry/tasks/seer/night_shift/cron.py

src/sentry/seer/autofix/utils.py

src/sentry/tasks/seer/night_shift/cron.py

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e704614. Configure here.}

src/sentry/tasks/seer/night_shift/cron.py

github-actions · 2026-04-14T19:58:23Z

Backend Test Failures

Failures on f53c8b2 in this run:

tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py::OrganizationAutofixAutomationSettingsEndpointTest::test_post_creates_project_preferences

— log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py:228: in test_post_creates_project_preferences
    assert preferences == [
E   AssertionError: assert [{'autofix_au...3760544, ...}] == [{'automated_...3826080, ...}]
E     
E     At index 0 diff: {'organization_id': 4557968173760544, 'project_id': 4557968173826080, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None, 'autofix_automation_tuning': None} != {'organization_id': 4557968173760544, 'project_id': 4557968173826080, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None}
E     
E     Full diff:
E       [
E           {
E     +         'autofix_automation_tuning': None,
E               'automated_run_stopping_point': 'open_pr',
E               'automation_handoff': None,
E               'organization_id': 4557968173760544,
E               'project_id': 4557968173826080,
E               'repositories': [],
E           },
E       ]

tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py::OrganizationAutofixAutomationSettingsEndpointTest::test_post_updates_each_preference_field_independently

— log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py:289: in test_post_updates_each_preference_field_independently
    assert preferences == [
E   AssertionError: assert [{'autofix_au...4940192, ...}] == [{'automated_...5005728, ...}]
E     
E     At index 0 diff: {'organization_id': 4557968174940192, 'project_id': 4557968175005728, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None, 'autofix_automation_tuning': None} != {'organization_id': 4557968174940192, 'project_id': 4557968175005728, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None}
E     
E     Full diff:
E       [
E           {
E     +         'autofix_automation_tuning': None,
E               'automated_run_stopping_point': 'open_pr',
E               'automation_handoff': None,
E               'organization_id': 4557968174940192,
E               'project_id': 4557968175005728,
E               'repositories': [],
E           },
E       ]

src/sentry/tasks/seer/night_shift/cron.py

github-actions · 2026-04-14T20:13:28Z

Backend Test Failures

Failures on f3190e8 in this run:

tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py::OrganizationAutofixAutomationSettingsEndpointTest::test_post_updates_each_preference_field_independently

— log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py:289: in test_post_updates_each_preference_field_independently
    assert preferences == [
E   AssertionError: assert [{'autofix_au...4184736, ...}] == [{'automated_...4250272, ...}]
E     
E     At index 0 diff: {'organization_id': 4557968234184736, 'project_id': 4557968234250272, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None, 'autofix_automation_tuning': None} != {'organization_id': 4557968234184736, 'project_id': 4557968234250272, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None}
E     
E     Full diff:
E       [
E           {
E     +         'autofix_automation_tuning': None,
E               'automated_run_stopping_point': 'open_pr',
E               'automation_handoff': None,
E               'organization_id': 4557968234184736,
E               'project_id': 4557968234250272,
E               'repositories': [],
E           },
E       ]

tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py::OrganizationAutofixAutomationSettingsEndpointTest::test_post_creates_project_preferences

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py:228: in test_post_creates_project_preferences
    assert preferences == [
E   AssertionError: assert [{'autofix_au...2939536, ...}] == [{'automated_...3005072, ...}]
E     
E     At index 0 diff: {'organization_id': 4557968232939536, 'project_id': 4557968233005072, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None, 'autofix_automation_tuning': None} != {'organization_id': 4557968232939536, 'project_id': 4557968233005072, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None}
E     
E     Full diff:
E       [
E           {
E     +         'autofix_automation_tuning': None,
E               'automated_run_stopping_point': 'open_pr',
E               'automation_handoff': None,
E               'organization_id': 4557968232939536,
E               'project_id': 4557968233005072,
E               'repositories': [],
E           },
E       ]

github-actions · 2026-04-14T20:28:30Z

Backend Test Failures

Failures on 927853a in this run:

tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py::OrganizationAutofixAutomationSettingsEndpointTest::test_post_updates_each_preference_field_independently

— log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py:289: in test_post_updates_each_preference_field_independently
    assert preferences == [
E   AssertionError: assert [{'autofix_au...3167136, ...}] == [{'automated_...3232672, ...}]
E     
E     At index 0 diff: {'organization_id': 4557968293167136, 'project_id': 4557968293232672, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None, 'autofix_automation_tuning': None} != {'organization_id': 4557968293167136, 'project_id': 4557968293232672, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None}
E     
E     Full diff:
E       [
E           {
E     +         'autofix_automation_tuning': None,
E               'automated_run_stopping_point': 'open_pr',
E               'automation_handoff': None,
E               'organization_id': 4557968293167136,
E               'project_id': 4557968293232672,
E               'repositories': [],
E           },
E       ]

tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py::OrganizationAutofixAutomationSettingsEndpointTest::test_post_creates_project_preferences

— log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/seer/endpoints/test_organization_autofix_automation_settings.py:228: in test_post_creates_project_preferences
    assert preferences == [
E   AssertionError: assert [{'autofix_au...2642848, ...}] == [{'automated_...2642848, ...}]
E     
E     At index 0 diff: {'organization_id': 4557968292642848, 'project_id': 4557968292642848, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None, 'autofix_automation_tuning': None} != {'organization_id': 4557968292642848, 'project_id': 4557968292642848, 'repositories': [], 'automated_run_stopping_point': 'open_pr', 'automation_handoff': None}
E     
E     Full diff:
E       [
E           {
E     +         'autofix_automation_tuning': None,
E               'automated_run_stopping_point': 'open_pr',
E               'automation_handoff': None,
E               'organization_id': 4557968292642848,
E               'project_id': 4557968292642848,
E               'repositories': [],
E           },
E       ]

…bility Replace direct SeerProjectRepository queries in _get_eligible_projects with bulk_read_preferences_from_sentry_db / bulk_get_project_preferences behind the seer-project-settings-read-from-sentry feature flag, matching the pattern used in context_engine_index and autofix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/TusCoPLrgCYHLxdSUeDTGIDPYU1f6BITAaO7rK6QDl0

srest2021

Helper looks good, thanks for writing this!

Only one nit, which is adding the tuning to SeerProjectPreference--Seer will drop the field when it gets included in writes, and the write preference helpers to Sentry DB won't write it either. Mind adding a clarifying comment to the write helpers? Or alternatively could just return tuples

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 14, 2026

vercel bot deployed to Preview April 14, 2026 16:34 View deployment

chromy marked this pull request as ready for review April 14, 2026 18:11

chromy requested a review from a team as a code owner April 14, 2026 18:11

vercel bot deployed to Preview April 14, 2026 18:12 View deployment

sentry-warden bot reviewed Apr 14, 2026

View reviewed changes

src/sentry/seer/autofix/utils.py Outdated Show resolved Hide resolved

sentry bot reviewed Apr 14, 2026

View reviewed changes

src/sentry/tasks/seer/night_shift/cron.py Show resolved Hide resolved

trevor-e approved these changes Apr 14, 2026

View reviewed changes

src/sentry/seer/autofix/utils.py Outdated Show resolved Hide resolved

src/sentry/tasks/seer/night_shift/cron.py Show resolved Hide resolved

chromy force-pushed the chromy/ref/night-shift-seer-project-settings branch from d01fd09 to e704614 Compare April 14, 2026 19:50

chromy requested a review from a team as a code owner April 14, 2026 19:50

vercel bot deployed to Preview April 14, 2026 19:52 View deployment

sentry-warden bot reviewed Apr 14, 2026

View reviewed changes

src/sentry/tasks/seer/night_shift/cron.py Outdated Show resolved Hide resolved

sentry bot reviewed Apr 14, 2026

View reviewed changes

src/sentry/tasks/seer/night_shift/cron.py Show resolved Hide resolved

cursor bot reviewed Apr 14, 2026

View reviewed changes

src/sentry/tasks/seer/night_shift/cron.py Show resolved Hide resolved

chromy force-pushed the chromy/ref/night-shift-seer-project-settings branch from e704614 to 8b8fe1d Compare April 14, 2026 19:59

vercel bot deployed to Preview April 14, 2026 20:01 View deployment

sentry bot reviewed Apr 14, 2026

View reviewed changes

src/sentry/tasks/seer/night_shift/cron.py Show resolved Hide resolved

chromy force-pushed the chromy/ref/night-shift-seer-project-settings branch from 8b8fe1d to a226560 Compare April 14, 2026 20:04

vercel bot deployed to Preview April 14, 2026 20:05 View deployment

chromy force-pushed the chromy/ref/night-shift-seer-project-settings branch from a226560 to 99c5a91 Compare April 14, 2026 20:13

vercel bot deployed to Preview April 14, 2026 20:15 View deployment

chromy force-pushed the chromy/ref/night-shift-seer-project-settings branch from 99c5a91 to b0f533f Compare April 14, 2026 20:19

vercel bot deployed to Preview April 14, 2026 20:21 View deployment

chromy force-pushed the chromy/ref/night-shift-seer-project-settings branch from b0f533f to cade023 Compare April 14, 2026 20:58

vercel bot deployed to Preview April 14, 2026 21:00 View deployment

chromy force-pushed the chromy/ref/night-shift-seer-project-settings branch from cade023 to 63d1544 Compare April 14, 2026 21:01

vercel bot deployed to Preview April 14, 2026 21:03 View deployment

srest2021 approved these changes Apr 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(night-shift): Use seer-project-settings helpers for project eligibility#112936

ref(night-shift): Use seer-project-settings helpers for project eligibility#112936
chromy wants to merge 1 commit intomasterfrom
chromy/ref/night-shift-seer-project-settings

chromy commented Apr 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

srest2021 left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

chromy commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backend Test Failures

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backend Test Failures

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backend Test Failures

Uh oh!

srest2021 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chromy commented Apr 14, 2026 •

edited

Loading

github-actions bot commented Apr 14, 2026 •

edited

Loading

github-actions bot commented Apr 14, 2026 •

edited

Loading

github-actions bot commented Apr 14, 2026 •

edited

Loading

srest2021 left a comment •

edited

Loading